Jump to content
Sign in to follow this  
johan.dejong

Platform 5 CSS breaks layout

Recommended Posts

johan.dejong

I'm currently testing Platform 5 to replace the DMS 2 themes we have for our clients and found a rather annoying "feature": the plugin has a huge amount of CSS (5000+ lines) which gets added to the theme and gives unexpected and unwanted results.

As it seems, the only way to prevent this from happening is overwriting every single line which breaks, for every theme and plugin which has CSS (so everything) to make it compatible with Platform 5.

 

One of the most annoying pieces of code is:

/** Don't nest, since we want base hierarchy for overriding */
.pl-sn-pad {
  padding: 1rem;
  display: -webkit-flex;
  display: -moz-flex;
  display: -ms-flexbox;
  display: -ms-flex;
  display: flex;
  -webkit-flex-direction: column;
  -moz-flex-direction: column;
  -ms-flex-direction: column;
  flex-direction: column;
  -webkit-justify-content: center;
  -moz-justify-content: center;
  -ms-justify-content: center;
  justify-content: center;
  background-size: cover;
  background-position: 50% 50%;
  position: relative;
  z-index: 3;
}

This class is used all over the place and is simply a container for all sections. Therefor it should not have a padding (it breaks design) or a z-index (again, breaks design).
Even the PL themes and plugins have CSS to override this class...

 

Please remove any mandatory CSS which is defining how a theme/design behaves, otherwise it will be impossible to build themes/designs or require a huge amount of work to make it compatible.

Share this post


Link to post
Share on other sites
Andrew

Can't you just override it with your desired behavior with a single CSS rule? 

e.g. #page .pl-sn-pad { // whatever you want }

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

×