[Solved] Search error / complication

[John Olsson+ 8]

Hello, i'm working on a webshop, and got this code to really boost the search within WP. But when adding this code to functions.php the front end media library search flipped totally, and not working at all, any ideas what's the problem?

function atom_search_where($where){
  global $wpdb;
  if (is_search())
    $where .= "OR (t.name LIKE '%".get_search_query()."%' AND {$wpdb->posts}.post_status = 'publish')";
  return $where;
}

function atom_search_join($join){
  global $wpdb;
  if (is_search())
    $join .= "LEFT JOIN {$wpdb->term_relationships} tr ON {$wpdb->posts}.ID = tr.object_id INNER JOIN {$wpdb->term_taxonomy} tt ON tt.term_taxonomy_id=tr.term_taxonomy_id INNER JOIN {$wpdb->terms} t ON t.term_id = tt.term_id";
  return $join;
}

function atom_search_groupby($groupby){
  global $wpdb;

  // we need to group on post ID
  $groupby_id = "{$wpdb->posts}.ID";
  if(!is_search() || strpos($groupby, $groupby_id) !== false) return $groupby;

  // groupby was empty, use ours
  if(!strlen(trim($groupby))) return $groupby_id;

  // wasn't empty, append ours
  return $groupby.", ".$groupby_id;
}

add_filter('posts_where','atom_search_where');
add_filter('posts_join', 'atom_search_join');
add_filter('posts_groupby', 'atom_search_groupby');

 

[Simon 248]

Hi John.

Firstly if you are going to copy 6 year old code from the internet be sure to namespace it or put it in a class you can be pretty sure other people have copied that code and even put it into 'premium' plugins.

So Ive done that for you.

Also, the snippet is using is_search() so ALL searches would be affected. I added a function to check that the post_type is not attachment.

class Olsson_Search {

  function __construct() {
    add_action( 'init', array( $this, 'init' ) );
  }

  function init() {

    add_filter( 'posts_where', array( $this, 'atom_search_where' ) );
    add_filter( 'posts_join', array( $this, 'atom_search_join' ) );
    add_filter( 'posts_groupby', array( $this, 'atom_search_groupby' ) );
  }

  function atom_search_where($where){
    global $wpdb;

    if ( is_search() && ! $this->is_attachment() ) {
      $where .= "OR (t.name LIKE '%" . get_search_query() . "%' AND {$wpdb->posts}.post_status = 'publish')";
    }
    return $where;
  }

  function atom_search_join($join){
    global $wpdb;

    if ( is_search() && ! $this->is_attachment() ) {
      $join .= "LEFT JOIN {$wpdb->term_relationships} tr ON {$wpdb->posts}.ID = tr.object_id INNER JOIN {$wpdb->term_taxonomy} tt ON tt.term_taxonomy_id=tr.term_taxonomy_id INNER JOIN {$wpdb->terms} t ON t.term_id = tt.term_id";
    }

    return $join;
  }

  function atom_search_groupby($groupby){
    global $wpdb;

    // we need to group on post ID
    $groupby_id = "{$wpdb->posts}.ID";
    if( ! is_search()
      || ! $this->is_attachment()
      || strpos( $groupby, $groupby_id ) !== false ) {
        return $groupby;
      }

    // groupby was empty, use ours
    if( ! strlen( trim( $groupby ) ) ) {
      return $groupby_id;
    }

    // wasn't empty, append ours
    return $groupby . ", " . $groupby_id;
  }

  function is_attachment() {
    return ( 'attachment' === get_query_var( 'post_type' ) ) ? true : false;
  }
}
new Olsson_Search;

 

[John Olsson+ 8]

Holy sh*t!

That's...awesome! BIG THANKS!

[John Olsson+ 8]

I found out that the function messes up the search -query a bit, it renders 3 results of the same products, look here.. @Simon ?

[John Olsson+ 8]

@Simon - Any ideas??

[Simon 248]

Going to be tricky, you need to use is_admin to make sure the code is NOT run in the admin area, problem is the media popup on the frontend is actually part of wp admin, so is_admin() will be true.

So not sure what to suggest.

[John Olsson+ 8]

That's ok Simon! I found out that with the plugin Relevanssi it does the job! Just assigning Products and Products-Brands to the index. Maybe good for other users. Cheers!