Viewer Theme Hooker Conflict with Toolset Views Plugin

[dawsonbarber+ 19]

(First: not sure why this was/is added to Viewer because I didn't select Viewer nor were any product prefix options available for selection).

 

I had some problems with an installation that uses Views quite extensively and, after deactivating all plugins and reactivating one by one, found that the "culprit" was Hooker.

 

With Hooker active on the site, key Views functionality does not work (e.g., post links are rendered effectively inactive).

 

As I'd already reached out to the Toolset support team, they did some debugging.

 

Here's a recap of their findings:

 

Basically, the problem is that both Views and Hooker use a different version of CodeMirror (script used for syntax highlighting). Views is using version 4.8.0 and Hooker is using version 3.19.

 

Further details:

• PageLines DMS Hooker plugin is en-queuing the CodeMirror script on every admin page although it is only using it on a single admin page, while Views is only en-queuing it on the pages it is using it
• Views registers and en-queues the CodeMirror script with an appropriate handler name, while Hooker is using a "test" name for it. It is also using the same "test" handler for the CodeMirror style sheet

Recommendations:

• Rename the CodeMirror script and style sheet handlers to something less generic than "test"
• Make sure that Hooker is only registering and en-queuing those assets on the admin page that uses them.

Sidenote: For what it;s worth, they also indicated that Hooker may not be fully compliant with the CodeMirror license as, apparently, it does not include the license declaration files.

 

Perhaps these issues can be addressed in an update?

 

[dawsonbarber+ 19]

A response would be appreciated.

[Danny+ 1,327]

Hi,

 

I will pass this onto our developers.

[Simon 248]

Plugin updated to 1.5.1 addresses this issue.

[dawsonbarber+ 19]

Awesome!