Jump to content

Archived

This topic is now archived and is closed to further replies.

Jackey

DMS 1.0.1 Section Padding

Recommended Posts

Jackey

All section padding is broken in 1.0.1:

style="padding-top: 40pxpx; padding-bottom: 0pxpx;"

Share this post


Link to post
Share on other sites
thebastion

I have no section padding issues, but your update has knocked seven shades out of Nick Haskins 'Projects' section.

 

Do you coordinate updates with your external section devs?

Share this post


Link to post
Share on other sites
Simon

padding entered:

http://screencast.com/t/M2Tnromhy4F

 

expected output?

http://screencast.com/t/qqOA98PPQSjR

 

 

I have no section padding issues, but your update has knocked seven shades out of Nick Haskins 'Projects' section.

 

Do you coordinate updates with your external section devs?

We have a totally open code repo, we push daily updates and 'most' of the 3rd party developers always pull the latest code, we hear from them 1st usually if there is an issue in core.

Share this post


Link to post
Share on other sites
Jackey

simon Not that one... the one of the Full width Section Area.  You can't enter it without "px" because you have to select it from the combo box. It then renders as style="padding-top: 40pxpx; padding-bottom: 0pxpx;"

 

 

http://i.imgur.com/kalVceh.png

Share this post


Link to post
Share on other sites
Jackey
Will take a few hours... Am traveling at the moment...

Suggest to make a normal entry field, and not a (limited) combo box.

Later...

Share this post


Link to post
Share on other sites
Jackey

Yes, that fixes it...

Share this post


Link to post
Share on other sites
Rob

Excellent!


Former PageLines Moderator, Food Expert and Raconteur

Share this post


Link to post
Share on other sites
soulhuntre

Do you coordinate updates with your external section devs?

 

The answer is, at this time, no. 

Hopefully that will change, but right now those of us who are devs working on sections get no notice of changes or releases, and we are not consulted about changes to the API or any similar decision.

Ken


-----------------------------------

Samurai Developer - WordPress and Enterprise level development in PHP, .NET and Node. 
 

Have a question about my services? Need help with a project? Just want to say hi? Go ahead and contact me!

 

Share this post


Link to post
Share on other sites
Armin

The fix is not working for me. My padding-top and padding-bottom of the section is still 0px.

 

Can you please fix this with a regular update? Besides that this fix is not working for me I don't want to fix this in all my installs manually.

Share this post


Link to post
Share on other sites
Jackey
The default padding also reset magically to 0px with update 1.0.1, I think we have to wait for 1.0.2.

Also found some class changes in the framework... So some custom css might need fixing.

Share this post


Link to post
Share on other sites
Armin

It is working now. Took some time apparently.

 

A regular update for this would still be great.

Share this post


Link to post
Share on other sites
Erwan

It is working now. Took some time apparently.

 

A regular update for this would still be great.


Hi Armin

Hmmm. What is exactly "working now after it took some time" for you?

  • either you have 1.0.1 with new issues introduced and reported here and there,
  • either you downloaded and installed the whole current DMS from GiThub repositery, or only some files/commits solving some of these issues (I use the two methods to check stuff),

but I din't see somewhere a magical unicorn updating your site without a regular update and solving things: if I missed it, could you please tell your unicorn to give me hand :)? I would really appreciate :)

Merci d'avance!

Share this post


Link to post
Share on other sites
Armin

Salut. 

 

I updated to DMS 1.0.1 and had the error with the missing padding on sections. Then I uploaded the new version of this file (dms/sections/pl-area/section.php) via FTP. The change occured after 10 minutes. I guess i just did not empty the cache of my browser.

Share this post


Link to post
Share on other sites
Erwan

Armin

 

Hallelujah! No unknow unicorns here then.

Friendly ;),

La France.

Share this post


Link to post
Share on other sites
Rob

:D


Former PageLines Moderator, Food Expert and Raconteur

Share this post


Link to post
Share on other sites

×