Jump to content


Photo
- - - - -
DMS2

Are there going to be improvements to "Enable CSS Classes" -feature?

css classes enable css classes pagelines pro

  • Please log in to reply
2 replies to this topic

#1 ketri

ketri

    Super Member

  • Members

  • 138 posts
  • Country: Country Flag

Posted 29 May 2014 - 03:07 PM

Hi!

When I use the Pagelines Pro plugin and enable the css classes there are some issues. First, it says:

This will add classes to the page, for example a desktop PC using firefox would add: <body class="home blog ... ... desktop firefox">

 

...but actually adds them to the <html>. Not problem but might confuse users. Also I only get 

 
class="mac chrome chrome3 webkit webkit5 csstransforms csstransforms3d csstransitions"

on desktop and 

 
class="iphone safari safari7 webkit webkit5"

on iPhone.

 

So I don't get i.e. the "desktop" class, "ios" -class, "mobile"/"phone" -class or "tablet" -class. Also classes to detect touch -devices etc would be great!

What kind of technology are you using for the detection and do you think there will be improvements? The best one I believe is mobile detect http://mobiledetect.net/, but it needs PHP and might be an issue with caching. So I've used https://github.com/b...noglu/Detectizr and have had great experiences.

Thanks!



#2 Simon_P

Simon_P

    Messer

  • Administrators



  • 8388607 posts
  • LocationDevon
  • Framework Version:2.1.1
  • Country: Country Flag

Posted 29 May 2014 - 06:18 PM

I know the js version adds it to the html element, the plugin we use is here: http://jquery.thewikies.com/browser/

 

The PHP version is way better but like you said it messes with caching, unless of course you have mobile bypass setup correctly.



#3 ketri

ketri

    Super Member

  • Members

  • 138 posts
  • Country: Country Flag

Posted 29 May 2014 - 07:38 PM

Thanks. 
Are there any thoughts on on developing this further at some point? 
Detectizr could be very nice for example. Of course there might be loads of stuff with a bigger priority...

 







Also tagged with one or more of these keywords: DMS2, css classes, enable css classes, pagelines pro