Jump to content


Photo
Tabber

The tabber's tab can't use Traditional Chinese.

chinese

  • Please log in to reply
8 replies to this topic

#1 kakadong

kakadong

    Super Member

  • Members

  • 113 posts
  • LocationTaiwan

Posted 29 March 2013 - 07:37 AM

If I enter the Traditional Chinese in Tabber tabs , it will become very very strange!!

 

So, I think just to use backgroud image to do the tricks .

 

But all tabs are the same class .

 

would you please consider to make your extension international ?

 

Or just gie evr tab a unique class so I can make them different .

 

 If not in Chinese Or can't use background , this extension is useless to me . 

 

http://www.sohokakad.../lucky/首頁/幸福會員/

 

Here is the links.

 

class= nothing   and If I use Chinese , the Tab won't work.



#2 kakadong

kakadong

    Super Member

  • Members

  • 113 posts
  • LocationTaiwan

Posted 29 March 2013 - 08:06 AM

Hi, I edit the sections.php 

 

change

 

 
$output .= sprintf('<li>%s</li>',$tabwhole);

 

 

to

 

 

 

 
$output .= sprintf('<li class="tabnum-%s">%s</li>',$i,$tabwhole);
 

 

then  I have <li class="tabnum-1"> something like this. 

 

And I don't think it is a good idea that you just use  

 
$tabnameclean = preg_replace('/[^\w]+/', '', $tabname);

 

 

Because all non-latin Language will become something like this in URL  %we3hsy%hruhdqrh%22kww62k 

so, if you just preg_replace , then everything break !!

 

I have bought a lot of your extensions , so I don't think it is the mistake you should make. 

 

Hope update it soon!  

 

Thanks.



#3 beardedavenger

beardedavenger

    Unicorn Wrangler

  • Members

  • 1219 posts
  • Country: Country Flag

Posted 01 April 2013 - 01:09 PM

Yup some settings need to be whitelisted so the option engine doesn't remove the characters. I'll push this on the next update.


  • kakadong likes this

#4 kakadong

kakadong

    Super Member

  • Members

  • 113 posts
  • LocationTaiwan

Posted 01 April 2013 - 08:12 PM

Thanks a lot !



#5 kakadong

kakadong

    Super Member

  • Members

  • 113 posts
  • LocationTaiwan

Posted 09 April 2013 - 07:40 AM

May I ask when will this update come out?



#6 kakadong

kakadong

    Super Member

  • Members

  • 113 posts
  • LocationTaiwan

Posted 12 April 2013 - 07:47 AM

It has been 11 days since your last reply.

 

May I ask you JUST WHEN I can get a patch?   



#7 beardedavenger

beardedavenger

    Unicorn Wrangler

  • Members

  • 1219 posts
  • Country: Country Flag

Posted 12 April 2013 - 01:22 PM

Please be patient.

 

I have over 30 products, that are continuously being updated. I just pushed 4 updates on 4 other products yesterday, along with spending the last 6 weeks finishing a clients project.



#8 kakadong

kakadong

    Super Member

  • Members

  • 113 posts
  • LocationTaiwan

Posted 29 April 2013 - 05:19 AM

one month passed........



#9 beardedavenger

beardedavenger

    Unicorn Wrangler

  • Members

  • 1219 posts
  • Country: Country Flag

Posted 29 April 2013 - 01:53 PM

This update isn't possible. Here's why. I whitelisted those option fields so the tab name can now read chinese and russian, etc. However, CSS doesn't let us apply those characters as an ID. The ID of the tab, matches the ID of the content. This is how it knows which tab to change to. Without being able to use languages in CSS it's just not possible.







Also tagged with one or more of these keywords: Tabber, chinese