Jump to content


Photo
- - - - -

Requesting Minor Change to Source Code re: Gallery Filter


Best Answer Danny , 18 February 2013 - 10:11 AM

HI,

 

I have reported this for you on your behalf, thanks for bring this to our attention.

Go to the full post


  • Please log in to reply
2 replies to this topic

#1 thomstark

thomstark

    Super Member

  • Members

  • 147 posts
  • Framework Version:Pagelines 2.37
  • Country: Country Flag

Posted 18 February 2013 - 01:29 AM

I installed a third party add-on plugin called "Nextgen Download Gallery," and I quickly found that there was a conflict between it and Pagelines. (With Pagelines disabled, it worked; enabled, it didn't.) It is an add-on to NextGen Gallery that allows you to select multiple gallery images for download, then zips them into a single archive. 

 

I contacted the plugin author and he (very quickly) responded. He checked out your source code (found in actions.site.php) and he said that the way it had been written, it disallowed any further custom gallery templates. The current PL source code reads:

 

function

Please Login or Register to see this Hidden Content

(

Please Login or Register to see this Hidden Content

,

Please Login or Register to see this Hidden Content

) {
if (

Please Login or Register to see this Hidden Content

== 'gallery-plcarousel')
return

Please Login or Register to see this Hidden Content

( '%s/carousel/gallery-plcarousel.php',

Please Login or Register to see this Hidden Content

);
else
return false;
}

 

 

Ross (the plugin author) said if you change "return false" to "return $a" it won't negate any other custom templates. I went ahead and made that small change in my core file just to see if he was correct, and indeed, changing "false" to "$a" removed the conflict between Pagelines and his plugin. 

 

Of course, I don't know much of anything about php, so maybe there's a good reason PL has written it this way, but if possible, I'm just writing to request this change be made official in the next update or so. 

 

Many thanks for your time. 



#2 Danny

Danny

    Is Awesome!

  • Moderators
  • 15064 posts
  • LocationManchester, UK
  • Country: Country Flag

Posted 18 February 2013 - 10:11 AM   Best Answer

HI,

 

I have reported this for you on your behalf, thanks for bring this to our attention.



#3 thomstark

thomstark

    Super Member

  • Members

  • 147 posts
  • Framework Version:Pagelines 2.37
  • Country: Country Flag

Posted 18 February 2013 - 05:14 PM

Thanks as always, Danny!