Jump to content


Photo
- - - - -

Ie Detection Maybe Not Correct?

IE internet explorer

Best Answer Simon_P , 01 December 2012 - 05:18 PM

yes works...

 

IE9 nothing happens.

IE8 Shim is loaded.

IE7 Shim + IE7 css is loaded. 

Go to the full post


  • Please log in to reply
6 replies to this topic

#1 hansinke

hansinke

    Member

  • Members
  • 13 posts
  • Framework Version:2.3

Posted 01 December 2012 - 03:05 PM

I could not find pl_detect_ie but found ie_version. I changed the code to: 

 

 

// Fix IE and special handling
// if ( pl_detect_ie() )
if ( ie_version())
pagelines_fix_ie();
 
and
 
function pagelines_fix_ie( ){
   
// $ie_ver = pl_detect_ie();
$ie_ver = ie_version();
 
maybe a bug?
 

 



#2 Simon_P

Simon_P

    Messer

  • Administrators
  • 8388607 posts
  • LocationDevon
  • Framework Version:2.0
  • Country: Country Flag

Posted 01 December 2012 - 04:47 PM

OK a bug how?

 

You have not explained what your bug is, what its doing and what you expect to happen and then what your fix does thats different.



#3 hansinke

hansinke

    Member

  • Members
  • 13 posts
  • Framework Version:2.3

Posted 01 December 2012 - 04:52 PM

When IE is detected the google code could appear in my header (when checked the function in the option panel). Initially I did not succeed to get it there. Then I took a look at the code and detected the function pl_detect_ie that should return true. But I coud not find thst function in pagelines. I found a similar function called ie_version in pagelines and that does the trick for me. Maybe I am wrong, but it seems that there is a naming /reference bug there.



#4 Simon_P

Simon_P

    Messer

  • Administrators
  • 8388607 posts
  • LocationDevon
  • Framework Version:2.0
  • Country: Country Flag

Posted 01 December 2012 - 05:00 PM

Do you have a URL where its not working?



#5 hansinke

hansinke

    Member

  • Members
  • 13 posts
  • Framework Version:2.3

Posted 01 December 2012 - 05:12 PM

Yes, I just did reset my fix: 

Please Login or Register to see this Hidden Content

Does it work in your environment correctly now?



#6 Simon_P

Simon_P

    Messer

  • Administrators
  • 8388607 posts
  • LocationDevon
  • Framework Version:2.0
  • Country: Country Flag

Posted 01 December 2012 - 05:18 PM   Best Answer

yes works...

 

IE9 nothing happens.

IE8 Shim is loaded.

IE7 Shim + IE7 css is loaded. 



#7 hansinke

hansinke

    Member

  • Members
  • 13 posts
  • Framework Version:2.3

Posted 01 December 2012 - 07:48 PM

Thanks! Great support. Resolved. I even found the function ;). Both functions are nearly similar and maybe one of both is not needed?!